Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 3rd party modules as esm #3251

Closed
wants to merge 6 commits into from
Closed

Use 3rd party modules as esm #3251

wants to merge 6 commits into from

Conversation

chmelevskij
Copy link
Member

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added build system improvement dependencies Pull requests that update a dependency file RN: REFACTOR labels Jan 16, 2023
@chmelevskij chmelevskij force-pushed the feat/3rd-party-packages-modules branch 2 times, most recently from 6d81ecc to db36888 Compare January 17, 2023 21:01
@haslinghuis
Copy link
Member

Could we make yarn test part of local checkout :)

/home/runner/work/betaflight-configurator/betaflight-configurator/src/js/tabs/osd.js
Error:   270:73  error  Missing trailing comma  comma-dangle

@chmelevskij
Copy link
Member Author

#3196

Or we could just add lint-staged like in that pr and this wouldn't even appear 😉

@chmelevskij chmelevskij force-pushed the feat/3rd-party-packages-modules branch from db36888 to 82477aa Compare January 20, 2023 06:59
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chmelevskij chmelevskij

Labels
build system improvement dependencies Pull requests that update a dependency file RN: REFACTOR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chmelevskij @haslinghuis