Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt issues and pull requests with a milestone from going stale. #2407

Merged

Conversation

mikeller
Copy link
Member

@mikeller mikeller commented Feb 8, 2021

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@McGiverGim
Copy link
Member

I suppose this is for a future? The exempt-all-milestones: true will only work when the PR that I linked is merged and published, it is not at this moment...

At this moment the only tag working...

exempt-milestones:
description: 'The milestones that mean an issue is exempt from being marked stale. Separate multiple milestones with commas (eg. "milestone1,milestone2").'

@mikeller
Copy link
Member Author

mikeller commented Feb 8, 2021

@McGiverGim: Good point, yes. Let's wait...

@McGiverGim
Copy link
Member

It has been merged, now we need to wait to the next release or use the main branch in the repo directly.

I think we can wait, but is your decision ;)

@mikeller
Copy link
Member Author

@McGiverGim: Yeah, let's wait - once the release is out, will we have to do something to update our integration to it?

@McGiverGim
Copy link
Member

I think that not, if the version does not pass to version 4:

@McGiverGim
Copy link
Member

Release 3.0.17 is out with the change. We can merge this and verify if it works...

@mikeller
Copy link
Member Author

@McGiverGim: As soon as it passes review. 😆

Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I forgot... 🤭

@mikeller mikeller merged commit 3435f07 into betaflight:master Feb 19, 2021
@mikeller mikeller deleted the exempt_milestones_from_staleness branch February 19, 2021 21:41
@mikeller
Copy link
Member Author

Removed the 'Has Milestone' label from #1324, watching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants