Fix/improve dynamicIdle hidding (#3624)

Fix dynamicIdle hidding removed unused api version import sinplify hidding, idlerpm disabled string improve revert simplifing simplifing digitalIdle hidding revert sinplifing
betaflight · Nov 2, 2023 · f83c460 · f83c460
1 parent af9ec79
commit f83c460
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/locales/en/messages.json b/locales/en/messages.json
@@ -4533,7 +4533,7 @@
         "message": "Dynamic Idle improves control at low rpm and reduces risk of motor desyncs. <br /><br /> It improves PID authority, zero throttle stability, inverted hang time, and motor braking.<br /><br />The Dynamic Idle min rpm should be set to around 3000 - 3500 rpm. <br /><br />Visit <a href=\"https://betaflight.com/docs/wiki/archive/Tuning-Dynamic-Idle\" target=\"_blank\" rel=\"noopener noreferrer\">this wiki entry</a> for more info."
     },
     "pidTuningIdleMinRpmDisabled": {
-        "message": "Dynamic Idle is OFF because Dshot Telemetry is OFF"
+        "message": "Dynamic Idle is DISABLED because Dshot Telemetry is OFF"
     },
     "pidTuningAcroTrainerAngleLimit": {
         "message": "Acro Trainer Angle Limit"

diff --git a/src/js/tabs/motors.js b/src/js/tabs/motors.js
@@ -12,7 +12,7 @@ import FC from "../fc";
 import MSP from "../msp";
 import { mixerList } from "../model";
 import MSPCodes from "../msp/MSPCodes";
-import { API_VERSION_1_42, API_VERSION_1_44, API_VERSION_1_46 } from "../data_storage";
+import { API_VERSION_1_42, API_VERSION_1_44 } from "../data_storage";
 import EscProtocols from "../utils/EscProtocols";
 import { updateTabList } from "../utils/updateTabList";
 import { isInt, getMixerImageSrc } from "../utils/common";
@@ -772,19 +772,8 @@ motors.initialize = async function (callback) {
 
             $('div.digitalIdlePercent').toggle(protocolConfigured && digitalProtocol);
 
-            if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) {
-                $('input[name="digitalIdlePercent"]').prop('disabled', protocolConfigured && digitalProtocol && FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry);
-            }
-
             if (FC.ADVANCED_TUNING.idleMinRpm && FC.MOTOR_CONFIG.use_dshot_telemetry) {
-                if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46)) {
-                    $('div.digitalIdlePercent').hide();
-                } else {
-                    const dynamicIdle = FC.ADVANCED_TUNING.idleMinRpm * 100;
-                    $('span.digitalIdlePercentDisabled').text(i18n.getMessage('configurationDigitalIdlePercentDisabled', { dynamicIdle }));
-                }
-            } else {
-                $('span.digitalIdlePercentDisabled').text(i18n.getMessage('configurationDigitalIdlePercent'));
+                $('div.digitalIdlePercent').hide();
             }
 
             $('.escSensor').toggle(protocolConfigured && digitalProtocol);

diff --git a/src/tabs/motors.html b/src/tabs/motors.html
@@ -107,9 +107,9 @@
                                         <div class="numberspacer">
                                             <input type="number" name="digitalIdlePercent" min="0.00" max="20.00" step="0.01"/>
                                         </div>
-                                        <span class="digitalIdlePercentDisabled"></span>
-                                        <div class="helpicon cf_tip" i18n_title="configurationDigitalIdlePercentHelp"></div>
+                                        <span i18n="configurationDigitalIdlePercent"></span>
                                     </label>
+                                    <div class="helpicon cf_tip" i18n_title="configurationDigitalIdlePercentHelp"></div>
                                 </div>
                                 <div class="number minthrottle">
                                     <label>