Skip to content

Commit

Permalink
Don't inherit secrets, pass as params (#3602)
Browse files Browse the repository at this point in the history
  • Loading branch information
blckmn authored Oct 10, 2023
1 parent de75f66 commit f2b88ec
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 2 deletions.
12 changes: 10 additions & 2 deletions .github/workflows/app-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,16 @@ on:
description: 'Specifies the path to use in the output of the build'
required: false
type: string
secrets: inherit

secrets:
AWS_S3_BUCKET:
required: true
AWS_ACCESS_KEY_ID:
required: true
AWS_SECRET_ACCESS_KEY:
required: true
AWS_REGION:
required: true

jobs:
test:
name: Test
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/app-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ jobs:
uses: ./.github/workflows/app-build.yml
with:
path: 'nightly'
secrets:
AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_REGION: ${{ secrets.AWS_REGION }}
5 changes: 5 additions & 0 deletions .github/workflows/app-weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ jobs:
uses: ./.github/workflows/app-build.yml
with:
path: 'weekly'
secrets:
AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_REGION: ${{ secrets.AWS_REGION }}

0 comments on commit f2b88ec

Please sign in to comment.