Make sonar happy

betaflight · Sep 21, 2024 · 2045b46 · 2045b46
1 parent 04ca343
commit 2045b46
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/js/serial_backend.js b/src/js/serial_backend.js
@@ -464,7 +464,7 @@ function checkReportProblems() {
 
         if (needsProblemReportingDialog) {
 
-            problems.map((problem) => {
+            problems.forEach((problem) => {
                 problemItemTemplate.clone().html(problem.description).appendTo(problemDialogList);
             });
 

diff --git a/src/js/tabs/options.js b/src/js/tabs/options.js
@@ -234,12 +234,12 @@ options.initMeteredConnection = function () {
     const result = getConfig("meteredConnection");
     $("div.meteredConnection input")
         .prop("checked", !!result.meteredConnection)
-        .change(function () {
+        .on('change', function () {
             setConfig({ meteredConnection: $(this).is(":checked") });
             // update network status
             ispConnected();
         })
-        .change();
+        .trigger('change');
 };
 
 // TODO: remove when modules are in place

diff --git a/src/js/utils/connection.js b/src/js/utils/connection.js
@@ -4,14 +4,6 @@ export function ispConnected() {
     const connected = navigator.onLine;
     const isMetered = getConfig('meteredConnection').meteredConnection;
 
-    if (!navigator.connection) {
-        return connected && !isMetered;
-    }
-
-    if (isMetered || navigator.connection.effectiveType === 'none' || !connected) {
-        return false;
-    }
-
-    return true;
+    return connected && !isMetered;
 }