QA output doc #80
Merged
QA output doc #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA doc outputs the underlying data used in charts for manual QA checks (added to .gitignore - don't commit)
Changes:
Sample argument (should be FALSE by default) has been added to the frequency table functions to display the values used in the calculations to spot check these are working correctly. The sample size (denominator) is also checked against the sample_sizes function run on the un-routed data, as an additional check that question routing logic is working.
Sample_sizes functions has been updated to correct logic
Cap_by_freq function has been updated to filter respondents with prior coding experience