New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fixture usage validator #8

Merged

mcproger merged 2 commits into best-doctor:master from micheller:master

Nov 24, 2020

Contributor

micheller commented Nov 23, 2020


          add fixture usage validator

469e3af

mcproger reviewed

View reviewed changes

flake8_fine_pytest/watchers/assert_count.py

@@ @@ -20,15 +20,12 @@ def _should_check(self) -> bool: @@
                   def _validate_assert_count(self, tree: ast.AST) -> None:
                       for node in ast.walk(tree):
-                          if self._is_properly_node(node) is False:

Contributor

mcproger Nov 24, 2020

I think the better solution is to move this method to BaseWatcher and override it if we need. I already suggested it in another PR


          make base methods for selecting checkable ast nodes.

8bb6981

mcproger merged commit 5f5b6a9 into best-doctor:master

lowitea mentioned this pull request

Adds unique tests names validator #7

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet