Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ocrd tool runtime #13

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

kba
Copy link
Collaborator

@kba kba commented Aug 20, 2024

  • Upgrade from draft 6 to draft 2019-09 for the deprecated meta-schema keyword
  • ocrd-tool.json is validated on the first call to Processor.metadata, i.e. when before processing
  • OcrdToolValidator uses the default-setting variant of the JSON Schema validator
  • The default-setting variant also checks whether any properties are deprecated and generates a warning
  • If there are any errors or warnings, these are logged.

Copy link
Owner

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

src/ocrd/processor/base.py Show resolved Hide resolved
src/ocrd/processor/base.py Show resolved Hide resolved
src/ocrd_validators/json_validator.py Show resolved Hide resolved
@kba kba force-pushed the validate-ocrd-tool-runtime branch from bd6faa7 to 346f166 Compare August 21, 2024 11:56
@bertsky bertsky merged commit 111a52e into bertsky:new-processor-api Aug 21, 2024
@kba kba deleted the validate-ocrd-tool-runtime branch August 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants