decoder: let get_simple() return NANOCBOR_OK, not number of bytes #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match the docs
This aligns with most of the other
nanocbor_get_*
functions that also returnNANOCBOR_OK
instead of the number of bytes read.However, while looking at this, I noticed the API to be slightly inconsistent as it returns the number of bytes for all number-related decoding functions such as
nanocbor_get_{uint*,int*,float,double}
. Was there a specific reason to do so or could we change those return values as well? In the end, the user shouldn't need to care about the amount of bytes that were consumed for a specific decoder function, right?