-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test output of csv #185
test output of csv #185
Conversation
@bensialih could you trim this, and make the script replaces quotes then trim, not trim then replace quotes. bcz in the current file export when you replace the quotes it isn't trimming. |
@bensialih there is the double space also we have 34 cases, so please add it to the script after removing the quotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bensialih for the first file it looks GOOD 👍✅ csv/algeria_cities_export.csv]
for the other ones they are made with the old script I think
1- I think we need to get rid of the double quotes "
2- there are places with double space
@seddik I will have a look this hopefully on Wednesday or next weekend. Hopefully next weekend I will make some more changes |
3313e40
to
fe0b0aa
Compare
test conversion script from json to csv