Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test output of csv #185

Merged
merged 19 commits into from
Jul 21, 2024
Merged

test output of csv #185

merged 19 commits into from
Jul 21, 2024

Conversation

bensialih
Copy link
Owner

test conversion script from json to csv

@seddik
Copy link
Collaborator

seddik commented May 26, 2024

@bensialih could you trim this, and make the script replaces quotes then trim, not trim then replace quotes. bcz in the current file export when you replace the quotes it isn't trimming.

image
image

@seddik
Copy link
Collaborator

seddik commented May 26, 2024

@bensialih there is the double space also we have 34 cases, so please add it to the script after removing the quotes
1- remove quotes
2- replace double spaces
3- trim (Left & Right)

image

Copy link
Collaborator

@seddik seddik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bensialih for the first file it looks GOOD 👍✅ csv/algeria_cities_export.csv]

for the other ones they are made with the old script I think
1- I think we need to get rid of the double quotes "
2- there are places with double space

@bensialih
Copy link
Owner Author

@seddik I will have a look this hopefully on Wednesday or next weekend. Hopefully next weekend I will make some more changes

@bensialih bensialih marked this pull request as ready for review July 20, 2024 13:37
@bensialih bensialih force-pushed the feature/migrate_to_csv_sql branch from 3313e40 to fe0b0aa Compare July 21, 2024 15:24
@bensialih bensialih linked an issue Jul 21, 2024 that may be closed by this pull request
@bensialih bensialih merged commit ba30990 into master Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate code from data (Python folder)
2 participants