Update printer.ts to support kind = 'get'/'set' on TSMethodSignature
#1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TSMethodSignature` has a `kind` property which can be set to `method` (the default), `get`, and `set`. When `get` and `set`, the method is a getter or a setter, and as such, should be prefixed with either `get ` or `set `.
|
Could you please add test for this? Or provide code example |
|
Added tests #1401 and landed in |
|
@coderaiser Apologies for the delayed response, and thank you for adding the tests! Would you like me to take additional action, or is it handled as needed in #1401? |
|
Some checks are failing in my PR, so if you fix this in your PR, I think it can make things go a bit faster :)... |
eventualbuddha
approved these changes
May 31, 2024
|
Published in v0.23.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSMethodSignaturehas akindproperty which can be set tomethod(the default),get, andset. Whengetandset, the method is a getter or a setter, and as such, should be prefixed with eithergetorset.