Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak grammar of non-failure alert #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tweak grammar of non-failure alert #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ async function handleAlert(benchName: string, curSuite: Benchmark, prevSuite: Be
} else {
core.debug(
`${len} alerts exceeding the alert threshold ${alertThreshold} were found but` +
` all of them did not exceed the failure threshold ${threshold}`,
` none of them exceeded the failure threshold ${threshold}`,
);
}
}
Expand Down