Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combinations import done #1
base: master
Are you sure you want to change the base?
Combinations import done #1
Changes from all commits
d5ae4cd
bd88981
7cd1ea4
a292bac
1ae3188
79070e4
17537d2
ea8ffcb
c1cd516
9df41d1
e272b89
83bd444
b18cb3b
cd62bb4
5b8fd1d
67ceb1e
7635a37
3a367be
7020314
9bd60bf
e5e9459
e7906eb
000bacc
49fb17e
0169055
0f3529e
33fc680
bec6158
62e02d3
fe0b2e2
be71126
59f37d0
c5f0bb4
16918b1
239ccd3
3000e88
ca2dc61
bce2b15
240a13f
f42277d
913688c
3e45013
7c685e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А здесь и ниже точно нужен каст? Тут тайпскрипт без проблем должен типы резолвить
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это по идее можно сделать женериком тогда каст на 26 строчке можно будет убрать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А тут кажется есть проблема с тем что ивент листенеры не удаляются. Вообще я бы подумал над тем чтоб ивентлистенер создавался только один раз
P.S responce -> response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
По идее тут тоже можно сделать дженерик чтоб не кастить, как по мне так красивее