Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try setting simpler version bounds instead #2

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

michaelwebb76
Copy link
Member

No description provided.

Copy link
Member

@JackKelly-Bellroy JackKelly-Bellroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your upper bounds were excluding versions you previously allowed, and it's safe to allow them until the next major version.

tasty-golden-extra.cabal Outdated Show resolved Hide resolved
tasty-golden-extra.cabal Outdated Show resolved Hide resolved
tasty-golden-extra.cabal Outdated Show resolved Hide resolved
tasty-golden-extra.cabal Outdated Show resolved Hide resolved
@JackKelly-Bellroy
Copy link
Member

This is the stanza I got to on my local branch, in case it helps (my local machine is still building/testing everything):

common deps
  build-depends:
    , aeson           >=2.1        && <2.3
    , aeson-diff      ^>=1.1.0.13
    , aeson-pretty    ^>=0.8.10
    , base            >=4.14       && <4.20
    , bytestring      >=0.10       && <0.13
    , pretty-show     ^>=1.10
    , pretty-simple   ^>=4.1.3.0
    , tasty           ^>=1.5.2
    , tasty-discover  ^>=5.0.0
    , tasty-golden    ^>=2.3.5
    , text            ^>=1.2       || ^>=2.0 || ^>=2.1
    , yaml            ^>=0.11.11.2

@michaelwebb76 michaelwebb76 merged commit 67c0e00 into master Dec 18, 2024
7 checks passed
@michaelwebb76 michaelwebb76 deleted the try-to-use-simpler-bounds branch December 18, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants