Remove new lines in function constructor #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
pushed a commit
to TooTallNate/quickjs
that referenced
this pull request
Jul 3, 2024
* Improve error handling - throw RangeError for invalid string length - throw RangeError for stack overflow with updated message - fix case for `BigInt` error messages - refine stack check for `next_token` and `json_next_token` - throw SyntaxError for too many variables, arguments, parameters... - v8.js: disable v8 specific tests - v8.js: disable Realm object tests - v8.js: disable MODULE tests - v8.js: disable RegExp static properties tests - use more precise error messages - reorder property lookup in `js_obj_to_desc()` according to ECMA - set global object's [Symbol.toStringTag] to "global" - fix error message for duplicate parameter name in strict mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that exceptions raised from functions created by "new Function" have "invalid" line numbers in stacktrace.
For example:
(new Function("throw new Exception('abc');"))()reports
(<input>:3)By removing two additional new line characters, exception reports line numbers matching code provided to Function constructor.