Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip escape config #143

Closed
wants to merge 1 commit into from
Closed

Conversation

yywing
Copy link

@yywing yywing commented Dec 12, 2024

No description provided.

@fgmarand
Copy link

I'm curious about the rationale for envisioning the idea of not escaping content, which could generate invalid markup. Also, this is missing tests.

@beevik
Copy link
Owner

beevik commented Jan 17, 2025

Same. I'm inclined to decline this pull request as I don't understand the use case.

@beevik
Copy link
Owner

beevik commented Jan 18, 2025

Rejecting pull request as it provides no justification for producing potentially invalid XML.

@beevik beevik closed this Jan 18, 2025
@fgmarand
Copy link

Interestingly, I just saw a similar request in Drupal 11 last week. The use case was for the RSS feed, to be able to accept pre-validated data from a trusted source and being able to output it as such. Like React dangerouslySetInnterHtml in React or the raw filter in Twig. So that could have been the idea. But without an explanation from the OP, better close it. It can still be reopened if needed anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants