sync-latest-fx-prices #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
As discussed, I would refrain from introducing the "multichain-schedule" for this. Would like a more generalized approach. |
gmbronco
force-pushed
the
latest-fx-price
branch
from
9ae113b to
0d31d7e
Compare
|
Removed multichain job in favour of chain specific ones. |
franzns
reviewed
Dec 19, 2023
modules/network/optimism.ts
Outdated
Comment on lines
412
to
415
| { | ||
| name: 'sync-latest-fx-prices', | ||
| interval: every(10, 'minutes'), | ||
| }, |
There was a problem hiding this comment.
we dont have fx pools on OP. not sure about the other chains
franzns
reviewed
Dec 19, 2023
modules/network/zkevm.ts
Outdated
Comment on lines
295
to
298
| { | ||
| name: 'sync-latest-fx-prices', | ||
| interval: every(10, 'minutes'), | ||
| }, |
There was a problem hiding this comment.
same, think they dont have fx pools
There was a problem hiding this comment.
true, FX is on: Mainnet, Polygon and Avalanche so far.
gmbronco
force-pushed
the
latest-fx-price
branch
from
0d31d7e to
8ccf9d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a job for syncing latest FX price from subgraph. The task itself is fast, so I'm scheduling it as one job for all the chains.
closes #565