Refactor/sor service #599
Merged
Refactor/sor service #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmbronco
approved these changes
Dec 18, 2023
modules/sor/sor.gql
Outdated
Comment on lines
24
to
35
| type GqlCowSwapApiResponse { | ||
| tokenAddresses: [String!]! | ||
| swaps: [GqlSwap!]! | ||
| swapAmount: String! | ||
| swapAmountForSwaps: String! | ||
| returnAmount: String! | ||
| returnAmountFromSwaps: String! | ||
| returnAmountConsideringFees: String! | ||
| tokenIn: String! | ||
| tokenOut: String! | ||
| marketSp: String! | ||
| } |
There was a problem hiding this comment.
perhaps we could already remove fields they don't use:
marketSp
returnAmountConsideringFees
swapAmountForSwaps
they didn't confirm which fields they use, didn't they?
There was a problem hiding this comment.
agree, will remove once I know what they use
| // args.swapAmount is RawScale, e.g. 1USDC should be passed as 1000000 | ||
| const amount = await getTokenAmountRaw(amountToken, args.swapAmount, args.chain!); | ||
|
|
||
| const swap = await sorV2Service.getSwapResult({ |
There was a problem hiding this comment.
yes, balancer chains dont support a V1
| // args.swapAmount is HumanScale | ||
| const amount = await getTokenAmountHuman(amountToken, args.swapAmount, args.chain!); | ||
|
|
||
| const swap = await this.getComparingSwap({ |
There was a problem hiding this comment.
i like the name vs getSwap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving, renaming and removing unused stuff.
Also adding on chain query for v2 swaps