Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only have one set of resolvers and schema, keep folders for dev #538

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

franzns
Copy link
Contributor

@franzns franzns commented Nov 21, 2023

addresses #523

@franzns franzns requested a review from gmbronco November 21, 2023 11:02
@franzns franzns linked an issue Nov 21, 2023 that may be closed by this pull request
Copy link
Contributor

@gmbronco gmbronco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gmbronco
Copy link
Contributor

btw. would it make sense to merge loadRestRoutesBeethoven + loadRestRoutesBalancer as well?

@franzns
Copy link
Contributor Author

franzns commented Nov 21, 2023

btw. would it make sense to merge loadRestRoutesBeethoven + loadRestRoutesBalancer as well?

I thought about it too, but it's not as important. I wanted to merge the schema because you could run into issues where a certain schema is deployed but not available. Can't happen with the restRoutes as they dont use codegen

That being said, might nevertheless make sense. I'm going to add it.

@franzns franzns merged commit be23e70 into v3-canary Nov 27, 2023
1 check passed
@franzns franzns deleted the feature/remove-protocolspecific-resolvers branch November 27, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove protocol specific resolvers
2 participants