Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 canary #530

Merged
merged 38 commits into from
Nov 16, 2023
Merged

V3 canary #530

merged 38 commits into from
Nov 16, 2023

Conversation

franzns
Copy link
Contributor

@franzns franzns commented Nov 15, 2023

Changes:

  • Chain filter for all pool queries
  • Chain filter for all user queries
  • Add balancerSubgraphService explicitly to all network configs to avoid network context dependency in subgraph service
  • introduction of services into network config
  • Generalize APR group naming
  • Removal of unused getUserSwapVolume query
  • vebalVotingGauge service will run even if a voting gauge throws an error but still log error and fail the cron check. this makes sure that a wrongly configured voting gauge does not stop the complete sync.
  • poolGetPools will also return blacklisted pools by default now.

@franzns franzns requested a review from gmbronco November 15, 2023 12:41
Comment on lines 9 to 11
textSearch: String
userAddress: String
): [GqlPoolMinimal!]!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it's a search param, but there is already where. is it ok to move it there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

Comment on lines 18 to 20
textSearch: String
userAddress: String
): Int!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@gmbronco
Copy link
Contributor

there is a missed chain filter in: user-snapshot.service.ts#350 - https://github.com/beethovenxfi/beethovenx-backend/pull/530/files#diff-8125d1292097bfe85b74b26610b4e1b7c4714e7dfd25be08cb1f508c3e32253aR350

should be:

                where: {
                    id_chain: { id: poolId, chain },
                },

@franzns
Copy link
Contributor Author

franzns commented Nov 16, 2023

there is a missed chain filter in: user-snapshot.service.ts#350 - https://github.com/beethovenxfi/beethovenx-backend/pull/530/files#diff-8125d1292097bfe85b74b26610b4e1b7c4714e7dfd25be08cb1f508c3e32253aR350

should be:

                where: {
                    id_chain: { id: poolId, chain },
                },

there was even more in there, thanks!

@franzns franzns merged commit 33b70b8 into v3-main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants