IB Yield APR Service - Adding new tokens and handlers #451
Conversation
Adding 2 new apr handlers, bloom and maker;
modules/network/avalanche.ts
Outdated
| tokenAddress: '0xa25eaf2906fa1a3a13edac9b9657108af7b703e3', | ||
| sourceUrl: 'https://ceres.gogopool.com', | ||
| path: 'ggAVAXMonthlyInterestMonth.value', | ||
| scale: -0.8333, |
There was a problem hiding this comment.
is there an explanation for this number?
There was a problem hiding this comment.
Yeah, according with solarcurve, the AVAX Monthly Interest must be multiplied by -12 to represent the APR in normal scale, for example, if the monthly interest is -0,15, the APR would be -0,15 * -12 = 1,8%, my understanding is that this number represents what the owner pays as interest, if he receives, it's negative, but I'll confirm this last statement with him.
Now, how this -12 became -8,333 (sorry, the -0,8333 was wrong, already fixed), it's because the scale parameter is used to divide the number, and the final apr percentage is in decimal format (1,8% = 0,018), so if
M * -12 = A (M is monthly rate and A is APR) => (M/x) = (A/100) => (A / -12x) = (A / 100) [replacing M by A/-12] => x = 100/-12 = -8,33333
There was a problem hiding this comment.
can you add this as a comment as well please?
| path: 'value', | ||
| group: 'OVERNIGHT', | ||
| }, | ||
| overnightstUSDPlus: { |
There was a problem hiding this comment.
same token different address?
There was a problem hiding this comment.
No, this is the stUSD+, the other one is the USD+
| continue; | ||
| } | ||
| const tokenApr = (Number(currentRate) - 10000) / 10000; | ||
| aprs[address] = { apr: tokenApr, isIbYield: isIbYield ?? false }; |
There was a problem hiding this comment.
why do isIbYield: isIbYield ?? false ? just set it to false
There was a problem hiding this comment.
I made like this because I didn't know if this apr handler would be used for non-ib-yield tokens in the future
Adding new tokens
Creating 2 new apr Handlers: Bloom and Maker;