-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Golang version #401
Merged
+16
−14
Merged
Bump Golang version #401
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c147c5c
Bump Golang version
matiasinsaurralde eba5313
Replace ioutil references
matiasinsaurralde 8febdb8
Update random to use new rand approach
matiasinsaurralde c5a01d0
Attempt to fix codon Optimize rand usage
matiasinsaurralde 7c07629
Merge branch 'main' of https://github.com/TimothyStiles/poly into pr/…
TimothyStiles 9f77db1
fixed version error and ran go mod tidy.
TimothyStiles f0c83aa
Pick using source instead of global rand
carreter 5ba063f
Remove deprecated random.Seed
carreter 9a69f28
changed go version in test.yml to 1.21
TimothyStiles 02592e8
bump to 1.21 in workflows.
TimothyStiles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this moved to be a direct dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure @carreter. It's used only in the
mash
package similar to how blake3 is only used in theseqhash
package. Both are direct dependencies here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah had to double check but murmur3 should have been a direct dependency to begin with @carreter. Good to merge?