-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add svb compression to slow5 #341
Conversation
Moving #328 here to merge with ioToBio. #328 (comment) is relevant - I think this is just looking ahead to blow5 compatibility. To quote the importance of just the svb compression:
This is without implementing the other tricks from blow5. I also added in examples for how to use the compression / decompression |
Continuing the thread from over there (#328 (comment)):
If this is the case, I think we should entirely hold off on merging this PR in favor of doing a |
Breaking it down into two parts: 1 blow5 vs svb, and 2 svb triviality I strongly disagree that blow5 fulfills the same use case:
I also disagree that svb is trivial:
I specifically talk about the use-case for other clients in the context comment. |
Thank you for the clarifications re: slow5+svb vs blow5 and svb triviality. I completely missed the context comment, so sorry! I'm on board with adding this functionality - reviewing now. |
Replaces #328 , merging this time with ioToBio instead to take advantage of the new parser format.