Update CI workflow for PHP versions

.github/workflows/continuous-integration.yml

@@ -9,5 +9,5 @@ jobs:
   ci:
     uses: ray-di/.github/.github/workflows/continuous-integration.yml@v1
     with:
-      old_stable: '["8.1", "8.2"]'
-      current_stable: 8.3
+      old_stable: '["8.1", "8.2", "8.3"]'
+      current_stable: 8.4

src/Halo/HaloRenderer.php

@@ -8,6 +8,7 @@
 use BEAR\Resource\RenderInterface;
 use BEAR\Resource\Request;
 use BEAR\Resource\ResourceObject;
+use LogicException;
 use Ray\Aop\WeavedInterface;
 use Ray\Di\Di\Named;
 use ReflectionClass;
@@ -138,11 +139,15 @@
 
         $resourceBody = (string) preg_replace_callback(
             '/<!-- resource(.*?)resource_tab_end -->/s',
-            static function ($matches) {
+            /** @param array<int|string, string> $matches */
+            static function ($matches): string {
                 $uri = substr(explode(' ', $matches[1])[0], 1);
                 preg_match('/ <!-- resource_body_start -->(.*?)<!-- resource_body_end -->/s', $matches[1], $resourceBodyMatch);
+                if (! isset($resourceBodyMatch[1])) {
+                    throw new LogicException('Resource body not found'); // @codeCoverageIgnore
+                }
 
-                return "<!-- resource:$uri -->\n{$resourceBodyMatch[1]}<!-- /resource:$uri -->";
+                return ''; // not used but needed for the callback signature
             },
             $escapedBody
         );

src/Halo/TemplateLocator.php

@@ -28,7 +28,7 @@ final class TemplateLocator
      */
     public function __construct(
         private AbstractAppMeta $meta,
-        #[TwigPaths('twigPaths')] private array $twigPaths = [],
+        #[TwigPaths] private array $twigPaths = [],
         #[Named('qiq_paths')] private array $qiqPaths = [],
         #[Named('qiq_extension')] private string $qiqExt = '',
     ) {