Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't give up on reading local header when given short reads #75

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

fasterthanlime
Copy link
Collaborator

Closes #74

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 64.11765% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 75.69%. Comparing base (d00ef26) to head (1603637).

Files Patch % Lines
rc-zip/src/fsm/entry/zstd_dec.rs 62.26% 20 Missing ⚠️
rc-zip/src/fsm/entry/lzma_dec.rs 65.38% 18 Missing ⚠️
rc-zip-tokio/src/entry_reader.rs 69.69% 10 Missing ⚠️
rc-zip-sync/src/entry_reader.rs 60.86% 9 Missing ⚠️
rc-zip/src/fsm/entry/mod.rs 50.00% 3 Missing ⚠️
rc-zip-tokio/src/read_zip.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   76.37%   75.69%   -0.68%     
==========================================
  Files          25       25              
  Lines        2455     2473      +18     
==========================================
- Hits         1875     1872       -3     
- Misses        580      601      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime fasterthanlime merged commit 7bac68a into main Mar 19, 2024
3 of 4 checks passed
@fasterthanlime fasterthanlime deleted the we-love-short-reads branch March 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Short reads makes rc-zip-tokio give up early
1 participant