Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rc-zip-tokio: Re-use cursor if it's at the right offset already #71

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented Mar 16, 2024

Closes #61

@fasterthanlime fasterthanlime enabled auto-merge (squash) March 16, 2024 20:05
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.95%. Comparing base (a26f09d) to head (84dc0c6).

❗ Current head 84dc0c6 differs from pull request most recent head 597bdb2. Consider uploading reports for the commit 597bdb2 to get more accurate results

Files Patch % Lines
rc-zip-tokio/src/read_zip.rs 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   75.81%   75.95%   +0.13%     
==========================================
  Files          25       25              
  Lines        2382     2404      +22     
==========================================
+ Hits         1806     1826      +20     
- Misses        576      578       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime fasterthanlime merged commit a34a302 into main Mar 16, 2024
3 checks passed
@fasterthanlime fasterthanlime deleted the no-cursor-at branch March 16, 2024 20:07
@fasterthanlime fasterthanlime mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: In ReadZipWithSize & async variants, re-use cursor if it still has the right offset?
1 participant