Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Introduce ReadZipStreaming trait #62

Merged
merged 23 commits into from
Feb 5, 2024

Conversation

fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented Feb 2, 2024

...with optional validation at the end. Closes #44

Also use method from local header
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 142 lines in your changes are missing coverage. Please review.

Comparison is base (c95749b) 74.27% compared to head (e1bc45c) 76.07%.

Files Patch % Lines
rc-zip-tokio/src/streaming_entry_reader.rs 72.94% 23 Missing ⚠️
rc-zip-sync/src/streaming_entry_reader.rs 69.86% 22 Missing ⚠️
rc-zip/src/parse/archive.rs 66.66% 17 Missing ⚠️
rc-zip/src/fsm/archive.rs 77.27% 15 Missing ⚠️
rc-zip/src/fsm/entry/mod.rs 83.52% 14 Missing ⚠️
rc-zip/src/parse/local_headers.rs 78.00% 11 Missing ⚠️
rc-zip/src/parse/eocd.rs 65.51% 10 Missing ⚠️
rc-zip/src/parse/extra_field.rs 66.66% 10 Missing ⚠️
rc-zip/src/corpus/mod.rs 92.10% 6 Missing ⚠️
rc-zip-tokio/src/read_zip.rs 83.33% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   74.27%   76.07%   +1.80%     
==========================================
  Files          24       25       +1     
  Lines        2192     2408     +216     
==========================================
+ Hits         1628     1832     +204     
- Misses        564      576      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime fasterthanlime changed the title Introduce "unsafe" streaming file reader Introduce ReadZipStreaming trait Feb 5, 2024
@fasterthanlime fasterthanlime marked this pull request as ready for review February 5, 2024 21:29
@fasterthanlime fasterthanlime changed the title Introduce ReadZipStreaming trait feat!: Introduce ReadZipStreaming trait Feb 5, 2024
@fasterthanlime fasterthanlime merged commit ac46ad8 into main Feb 5, 2024
4 of 5 checks passed
@fasterthanlime fasterthanlime deleted the unsafe-streaming-reader branch February 5, 2024 21:33
@fasterthanlime fasterthanlime mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add unsafe sync reader based on local entries
2 participants