Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rc-zip-sync, rc-zip-tokio #60

Merged
merged 49 commits into from
Feb 2, 2024
Merged

Introduce rc-zip-sync, rc-zip-tokio #60

merged 49 commits into from
Feb 2, 2024

Conversation

fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented Feb 1, 2024

This (WIP) aims to close #45.

Async Rust is a tad friendlier now, let's see how it works out this time.

(Although my ultimate goal is to tackle #44, adding back the async interface is needed to make sure the state machines are truly sans-io, and to figure out what the API should look like.)

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 485 lines in your changes are missing coverage. Please review.

Comparison is base (1016c80) 71.85% compared to head (a532d35) 74.27%.

Files Patch % Lines
rc-zip/src/parse/mode.rs 24.39% 93 Missing ⚠️
rc-zip/src/parse/archive.rs 43.66% 40 Missing ⚠️
rc-zip/src/fsm/entry/mod.rs 78.80% 39 Missing ⚠️
rc-zip/src/parse/version.rs 22.00% 39 Missing ⚠️
rc-zip/src/parse/extra_field.rs 75.22% 27 Missing ⚠️
rc-zip/src/parse/local.rs 73.73% 26 Missing ⚠️
rc-zip/src/fsm/archive.rs 76.28% 23 Missing ⚠️
rc-zip/src/parse/eocd.rs 84.13% 23 Missing ⚠️
rc-zip/src/fsm/entry/deflate_dec.rs 73.17% 22 Missing ⚠️
rc-zip/src/fsm/entry/lzma_dec.rs 77.55% 22 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   71.85%   74.27%   +2.41%     
==========================================
  Files          21       24       +3     
  Lines        1549     2192     +643     
==========================================
+ Hits         1113     1628     +515     
- Misses        436      564     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime fasterthanlime changed the title Add tokio AsyncRead support Introduce rc-zip-sync, rc-zip-tokio Feb 1, 2024
@fasterthanlime fasterthanlime marked this pull request as ready for review February 2, 2024 19:21
@fasterthanlime fasterthanlime merged commit 2a0d894 into main Feb 2, 2024
5 checks passed
@fasterthanlime fasterthanlime deleted the tokio-read branch February 2, 2024 19:27
@fasterthanlime fasterthanlime mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Re-add async interface
2 participants