Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deflate64 method #43

Merged
merged 5 commits into from
Jan 27, 2024
Merged

feat: Add deflate64 method #43

merged 5 commits into from
Jan 27, 2024

Conversation

fasterthanlime
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ec8144) 77.60% compared to head (b200a79) 77.87%.

❗ Current head b200a79 differs from pull request most recent head 6a578f5. Consider uploading reports for the commit 6a578f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   77.60%   77.87%   +0.27%     
==========================================
  Files          19       20       +1     
  Lines        1759     1781      +22     
==========================================
+ Hits         1365     1387      +22     
  Misses        394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime
Copy link
Collaborator Author

This is failing on a large sample with this:

❯ jean unzip nystatehealthcosts2016-2021.zip
thread 'main' panicked at crates/jean/src/main.rs:72:18:
called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: Format(WrongSize { expected: 5530553199, actual: 114916728 }) }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

...where 7-zip is succeeding, so it's time to debug some!

@fasterthanlime fasterthanlime enabled auto-merge (squash) January 27, 2024 17:36
@fasterthanlime fasterthanlime enabled auto-merge (squash) January 27, 2024 17:36
@fasterthanlime fasterthanlime merged commit 1507282 into main Jan 27, 2024
3 checks passed
@fasterthanlime fasterthanlime deleted the deflate64 branch January 27, 2024 17:37
This was referenced Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants