Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse zip64 files produced by Windows 11 #33

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Conversation

fasterthanlime
Copy link
Collaborator

cf. #31

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ab5e9d1) 74.01% compared to head (e0ca548) 73.67%.

❗ Current head e0ca548 differs from pull request most recent head 17f028d. Consider uploading reports for the commit 17f028d to get more accurate results

Files Patch % Lines
crates/rc-zip/src/reader/archive_reader.rs 16.66% 5 Missing ⚠️
crates/rc-zip/src/format/eocd.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   74.01%   73.67%   -0.34%     
==========================================
  Files          17       17              
  Lines        1674     1683       +9     
==========================================
+ Hits         1239     1240       +1     
- Misses        435      443       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime fasterthanlime marked this pull request as ready for review January 26, 2024 15:24
@fasterthanlime fasterthanlime merged commit cad55f0 into main Jan 26, 2024
3 checks passed
@fasterthanlime fasterthanlime deleted the win11-zip64 branch January 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants