Fix: fix memory leak in endpoint buffer #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleviminzi
approved these changes
Dec 21, 2024
luke-lombardi
commented
Dec 21, 2024
| @@ -30,7 +32,7 @@ func (t *EndpointTask) Execute(ctx context.Context, options ...interface{}) erro | |||
| return err | |||
| } | |||
|
|
|||
| return instance.buffer.ForwardRequest(echoCtx, t) | |||
| return instance.buffer.ForwardRequest(echoCtx, t, payload) | |||
There was a problem hiding this comment.
This is a little hacky, but it makes sure that endpoint request payloads don't get stored in redis along with the rest of the task message. Since endpoint tasks don't support retries, this isn't necessary and wastes redis memory.
luke-lombardi
commented
Dec 21, 2024
| @@ -176,6 +173,11 @@ func (rb *RequestBuffer) processRequests() { | |||
| continue | |||
| } | |||
|
|
|||
| if req.ctx.Request().Context().Err() != nil { | |||
There was a problem hiding this comment.
If the client hung up by the time we're handling this request (error is not nil even if the context is just cancelled), then we should just mark this task as canceled and move on to the next item in the request buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Still need to reproduce this locally before merging