Skip to content

Commit

Permalink
fix typo w/ preemptable flag (#784)
Browse files Browse the repository at this point in the history
  • Loading branch information
luke-lombardi authored Dec 12, 2024
1 parent 7ca84e7 commit d4ea465
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions pkg/scheduler/pool_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ func (m *WorkerPoolManager) GetPool(name string) (*WorkerPool, bool) {

type poolFilters struct {
GPUType string
// Preemptible *bool
// TODO: add preemptible filter back once we have better ways of handling pool state
// Preemptable *bool
// TODO: add preemptable filter back once we have better ways of handling pool state
// (i.e. if a worker is not appearing in a certain pool)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/scheduler/pool_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func TestWorkerPoolManager_GetPoolByFilters(t *testing.T) {
manager := NewWorkerPoolManager()

controller := &LocalWorkerPoolControllerForTest{
preemptible: true,
preemptable: true,
}

// Set up test pools with different configurations
Expand Down
4 changes: 2 additions & 2 deletions pkg/scheduler/scheduler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ type LocalWorkerPoolControllerForTest struct {
name string
config types.AppConfig
workerRepo repo.WorkerRepository
preemptible bool
preemptable bool
}

func (wpc *LocalWorkerPoolControllerForTest) Context() context.Context {
return wpc.ctx
}

func (wpc *LocalWorkerPoolControllerForTest) IsPreemptable() bool {
return wpc.preemptible
return wpc.preemptable
}

func (wpc *LocalWorkerPoolControllerForTest) generateWorkerId() string {
Expand Down

0 comments on commit d4ea465

Please sign in to comment.