fix task cancellation status bug

beam-cloud · Dec 18, 2024 · a28b24e · a28b24e
1 parent 79d0373
commit a28b24e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/abstractions/taskqueue/task.go b/pkg/abstractions/taskqueue/task.go
@@ -70,6 +70,11 @@ func (t *TaskQueueTask) Cancel(ctx context.Context, reason types.TaskCancellatio
 		return err
 	}
 
+	// Don't update tasks that are already in a terminal state
+	if task.Status.IsCompleted() {
+		return nil
+	}
+
 	switch reason {
 	case types.TaskExpired:
 		task.Status = types.TaskStatusExpired