Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gotcha to the README #37

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add a gotcha to the README #37

merged 2 commits into from
Nov 29, 2023

Conversation

haberdashPI
Copy link
Member

As the title says

@haberdashPI haberdashPI self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a41c928) 95.97% compared to head (0698376) 95.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files           1        1           
  Lines         273      273           
=======================================
  Hits          262      262           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SimonDanisch SimonDanisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! If one thinks about it, it's obvious, but with the ability to hash deeply nested structs its easy to forget about it.

@SimonDanisch
Copy link
Contributor

@haberdashPI haberdashPI merged commit e8677d2 into main Nov 29, 2023
5 of 7 checks passed
@haberdashPI haberdashPI deleted the dfl/hashing-gotchas branch November 29, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants