WIP: Support BDF trigger + status channels #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, you're reading that correctly. It's not uncommon to encode things with a bit mask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #60 and the BioSemi format description. Basically the approach here is that we read the "status" signal into its own dedicated type that sits alongside
EDF.SignalandEDF.AnnotationsSignal. When reading the actual values, we take the first two bytes as the trigger and the last as the status. If I'm reading BioSemi's description correctly, the individual bits of these signals mean something, so I've opted for now to read them asUInt16andUInt8rather than some other 2-byte type andBool.Still to do: More thorough understanding + tests.