Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifying influxes service after config change #140

Merged
merged 4 commits into from
Mar 6, 2017
+2 −0
Merged

notifying influxes service after config change #140

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebbafd4
notifying influxes service after config change
Feb 20, 2017
2cc41ed
Rubocop fixes
Feb 21, 2017
58b3321
Rubocop fixes
Feb 21, 2017
dfb0b7b
Starting the influxdb service
Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion recipes/default.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@

influxdb_config node['influxdb']['config_file_path'] do
config node['influxdb']['config']
notifies :restart, 'service[influxdb]', :delayed
end

service 'influxdb' do
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is making kitchen tests fail.

       Recipe: influxdb-test::default
         * influxdb_database[test_database] action createE, [2017-02-22T01:02:14.764101 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.01s.
       E, [2017-02-22T01:02:14.775251 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.02s.
       E, [2017-02-22T01:02:14.795949 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.04s.
       E, [2017-02-22T01:02:14.837212 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.08s.
       E, [2017-02-22T01:02:14.919112 #268] ERROR -- InfluxDB: Failed to contact host

Was there a reason why you removed it?

FYI, on initial setup of the cookbook, we require influxdb to be running so we can do some initialization of the database. ref: https://github.com/bdangit/chef-influxdb/blob/master/test/fixtures/cookbooks/influxdb-test/recipes/default.rb#L5-L8

This is at least assuming the user needs to setup the db right after the service has been installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when we change the influxdb config or create it for first time it should start the service. So I removed that.

action [:enable, :start]
supports(restart: true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if influxdb config change is not starting influxdb then I think the rubocop fixes are not good for chef.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nilroy, the changes rubocop makes is all syntax reasons. Function should be unaffected.

If the desire is to restart the service when there is a new influxdb_config change, then what you have will work.

action :enable
end