This got a syntax error.

RuboCop failed!
Running RuboCop...
Inspecting 27 files
...............C...........

Offenses:

recipes/default.rb:26:12: C: Use the new Ruby 1.9 hash syntax.
  supports :restart => true
           ^^^^^^^^^^^

I think this would work:

  supports { restart: true }

I think Ruby will interpret that as a block. But you can use supports(restart: true)

thanks @alex-tan, you are right. supports(restart: true) compiles correctly.

I don't know why rubocop is complaining it. Because in chef documentation they followed the same syntax in examples https://docs.chef.io/resource_service.html.

@nilroy because Rubocop enforces a certain style of Ruby. restart: true and :restart => true are equivalent in the interpreter's eyes but some people like the style of the former better.

this line is making kitchen tests fail.

       Recipe: influxdb-test::default
         * influxdb_database[test_database] action createE, [2017-02-22T01:02:14.764101 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.01s.
       E, [2017-02-22T01:02:14.775251 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.02s.
       E, [2017-02-22T01:02:14.795949 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.04s.
       E, [2017-02-22T01:02:14.837212 #268] ERROR -- InfluxDB: Failed to contact host localhost: #<Errno::ECONNREFUSED: Connection refused - connect(2) for "localhost" port 8086> - retrying in 0.08s.
       E, [2017-02-22T01:02:14.919112 #268] ERROR -- InfluxDB: Failed to contact host 

Was there a reason why you removed it?

FYI, on initial setup of the cookbook, we require influxdb to be running so we can do some initialization of the database. ref: https://github.com/bdangit/chef-influxdb/blob/master/test/fixtures/cookbooks/influxdb-test/recipes/default.rb#L5-L8

This is at least assuming the user needs to setup the db right after the service has been installed.

I think when we change the influxdb config or create it for first time it should start the service. So I removed that.

I think when we change the influxdb config or create it for first time it should start the service. So I removed that.

But if influxdb config change is not starting influxdb then I think the rubocop fixes are not good for chef.

hi @nilroy, the changes rubocop makes is all syntax reasons. Function should be unaffected.

If the desire is to restart the service when there is a new influxdb_config change, then what you have will work.

hi @nilroy, the changes rubocop makes is all syntax reasons. Function should be unaffected.

If the desire is to restart the service when there is a new influxdb_config change, then what you have will work.