Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to npm for now. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nodech
Copy link
Member

@nodech nodech commented May 3, 2022

Because all handshake is using npm until we decide to switch everything to git (so tools can do proper dedups and etc), I believe it makes sense to release updates to npm and use npm for now.

"bsert": "git+https://github.com/chjj/bsert.git#semver:~0.0.10",
"bufio": "git+https://github.com/bcoin-org/bufio.git#semver:~1.0.6",
"loady": "git+https://github.com/chjj/loady.git#semver:~0.0.1"
"bcrypto": "~5.4.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially wait for [email protected] to be published on npm.

@nodech
Copy link
Member Author

nodech commented May 3, 2022

Okay,

[email protected] is not published on npm (as mentioned in above comment) and also only adds bech32m support that is not necessary for hsd and those changes were modified and not tagged yet. (Build fails on windows)

So we should continue using [email protected] for bfilter/npm version and bump the major to 3.0.
Until bcrypto is sorted out. I doubt we will need to update bfilter/bcrypto for bcoin in near future, but in case we do we can just branch out from [email protected] and bump minor if it's a minor fix or something. (highly unlikely)

@nodech nodech closed this May 3, 2022
@nodech nodech reopened this May 3, 2022
@pinheadmz
Copy link
Member

Ok as discussed I think we should hold off on this kind of move until we're ready to make a big change to hsd like to GPK, maybe in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants