Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORV2-2161: added initial cypress test cases #1327

Closed
wants to merge 90 commits into from
Closed

ORV2-2161: added initial cypress test cases #1327

wants to merge 90 commits into from

Conversation

bcgov-brwang
Copy link
Collaborator

@bcgov-brwang bcgov-brwang commented Apr 9, 2024 •
edited by github-actions bot
Loading

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

cberg-aot
cberg-aot approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@cberg-aot cberg-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid! great first test to integrate

erikataot
erikataot approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@erikataot erikataot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

cberg-aot
cberg-aot reviewed Jun 24, 2024
View reviewed changes
frontend/cypress.config.ts
Copy link
Collaborator

@cberg-aot cberg-aot Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all env except username/password & url. Refactor to import from .env

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcgov-brwang using IDIR_ for login info

cberg-aot
cberg-aot reviewed Jun 24, 2024
View reviewed changes
.github/workflows/.tests.yml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cberg-aot Remove CYPRESS_ variables. ICEPAY_USERNAME, ICEPAY_PASSWORD & ICEPAY_URL will be added

cberg-aot
cberg-aot reviewed Jun 24, 2024
View reviewed changes
frontend/cypress/e2e/home-page.cy.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

cberg-aot
cberg-aot reviewed Jun 24, 2024
View reviewed changes
...ete -- should complete an application from scratch with an existing test acount (failed).png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore screenshots @cberg-aot

cberg-aot
cberg-aot reviewed Jun 24, 2024
View reviewed changes
frontend/cypress/support/commands.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Passed Quality Gate passed for 'onroutebc frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cberg-aot cberg-aot cberg-aot approved these changes

@krishnan-aot krishnan-aot Awaiting requested review from krishnan-aot krishnan-aot is a code owner

@zgong-gov zgong-gov Awaiting requested review from zgong-gov zgong-gov is a code owner

@john-fletcher-aot john-fletcher-aot Awaiting requested review from john-fletcher-aot john-fletcher-aot is a code owner

@gchauhan-aot gchauhan-aot Awaiting requested review from gchauhan-aot gchauhan-aot is a code owner

@praju-aot praju-aot Awaiting requested review from praju-aot praju-aot is a code owner

@erikataot erikataot Awaiting requested review from erikataot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcgov-brwang @cberg-aot @erikataot @krishnan-aot @cpberg