Feat: ORV2-1933 Cleanup PayBC Redirection Flow #1159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikataot
requested review from
gchauhan-aot,
praju-aot,
krishnan-aot and
zgong-gov
as code owners
zgong-gov
reviewed
Feb 9, 2024
frontend/src/features/permits/pages/Payment/PaymentRedirect.tsx
Outdated
Show resolved
Hide resolved
| const ids:string[] = []; | ||
| getPaymentByTransactionId(transactionId) | ||
| .then((response) => { | ||
| response?.applicationDetails?.forEach((application) => { |
There was a problem hiding this comment.
Shouldn't we use a useQuery for this?
|
|
||
| if (permitIdsArray.length === 0) { | ||
| if (applicationIds?.length === 0) { |
There was a problem hiding this comment.
Line 74 and Line 76 are contradictory if checks. applicationIds?.length > 0 and applicationIds?.length === 0
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
??that was appearingFixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to: