feat: add HTML semantics #1742
Open
feat: add HTML semantics #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
ngunner15
requested review from
xiaopeng0202,
mgaseta,
DerekRoberts and
SLDonnelly
as code owners
mgaseta
approved these changes
Nov 25, 2024
Comment on lines
+91
to
+92
| type="button" | ||
| role="button" |
There was a problem hiding this comment.
Do we really need both the type and role? Shouldn't one be enough?
There was a problem hiding this comment.
Yes, we don't need role, only type is necessary for semantic HTML.
There was a problem hiding this comment.
I think you removed on the other button, this one still has both :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1722
Changelog
New
Changed
Removed
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: