Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe:FSADT1-1573): create client detail skeleton #1324

Merged
merged 24 commits into from
Nov 21, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Nov 18, 2024

Description

  • Adds feature flag STAFF_CLIENT_DETAIL;
  • Adds a route to the client detail page;
  • Adds the UI skeleton;
  • Updates e2e tests so the specific behavior can be tested with the feature flag both enabled and disabled.

Also adds an unrelated stub for predictive search error.

Fixes FSADT1-1573

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Current changelog

Features

  • add client details page skeleton (87907d9)
  • update redirect url from client search (8179e7c)
  • update roles allowed (749303d)

Reverts

  • Revert "test: remove tests where FF is off" (3a6e142)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants