-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[To Main] Feature - DESENG-636 - Add new engagement view page #2536
[To Main] Feature - DESENG-636 - Add new engagement view page #2536
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2536 +/- ##
==========================================
+ Coverage 75.93% 75.94% +0.01%
==========================================
Files 603 603
Lines 21755 21758 +3
Branches 1667 1667
==========================================
+ Hits 16519 16525 +6
+ Misses 4973 4970 -3
Partials 263 263
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just update the ticket number to https://apps.itsm.gov.bc.ca/jira/browse/DESENG-636 and you're set!
@@ -1,5 +1,5 @@ | |||
import React from 'react'; | |||
import '@bcgov/design-tokens/css-prefixed/variables.css'; | |||
import '@bcgov/design-tokens/css-prefixed/variables.css'; // Variables will be within scope within AuthenticatedLayout and its children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏻
Co-authored-by: Baelx <[email protected]>
Quality Gate passedIssues Measures |
Issue #: 🎟️ DESENG-636
Description of changes:
Feature Add a new engagemnt view page at
/gdx/new-look/[name]/[language]
/gdx/new-look/[name]/[language]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).