Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Feature - DESENG-636 - Add new engagement view page #2536

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

NatSquared
Copy link
Contributor

@NatSquared NatSquared commented Jun 7, 2024

Issue #: 🎟️ DESENG-636

Description of changes:

  • Feature Add a new engagemnt view page at /gdx/new-look/[name]/[language]

    • Added a new page to view engagements using the new look for MET
    • The page is available at /gdx/new-look/[name]/[language]
    • The page is a work in progress and will be updated in the future

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (67f1210) to head (7f45cbf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
+ Coverage   75.93%   75.94%   +0.01%     
==========================================
  Files         603      603              
  Lines       21755    21758       +3     
  Branches     1667     1667              
==========================================
+ Hits        16519    16525       +6     
+ Misses       4973     4970       -3     
  Partials      263      263              
Flag Coverage Δ
metweb 64.48% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-web/src/components/common/index.tsx 92.22% <ø> (ø)
met-web/src/components/common/Layout/index.tsx 85.71% <66.66%> (+19.04%) ⬆️

@NatSquared NatSquared changed the title Initial commit [To Main] Feature - DESENG-628 - Add new engagement view page Jun 7, 2024
@NatSquared NatSquared marked this pull request as ready for review June 7, 2024 00:41
Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just update the ticket number to https://apps.itsm.gov.bc.ca/jira/browse/DESENG-636 and you're set!

CHANGELOG.MD Outdated Show resolved Hide resolved
@@ -1,5 +1,5 @@
import React from 'react';
import '@bcgov/design-tokens/css-prefixed/variables.css';
import '@bcgov/design-tokens/css-prefixed/variables.css'; // Variables will be within scope within AuthenticatedLayout and its children
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@NatSquared NatSquared changed the title [To Main] Feature - DESENG-628 - Add new engagement view page [To Main] Feature - DESENG-636 - Add new engagement view page Jun 10, 2024
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NatSquared NatSquared merged commit 72f0907 into main Jun 10, 2024
8 checks passed
@NatSquared NatSquared deleted the feature/DESENG-636-add-enagement-new-look-route branch June 10, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants