Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Removing EAO process widget #2531

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-626

Description of changes:

  • Removed EAO process widget
  • Added migration file to remove EAO process widget attached to any existing engagement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.96%. Comparing base (0e58785) to head (b9a5d53).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
- Coverage   75.99%   75.96%   -0.03%     
==========================================
  Files         619      604      -15     
  Lines       22094    21784     -310     
  Branches     1702     1666      -36     
==========================================
- Hits        16791    16549     -242     
+ Misses       5038     4972      -66     
+ Partials      265      263       -2     
Flag Coverage Δ
metapi 87.88% <ø> (-0.01%) ⬇️
metweb 64.55% <57.14%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/constants/widget.py 100.00% <ø> (ø)
...gement/form/EngagementWidgets/WidgetCardSwitch.tsx 18.36% <ø> (+1.70%) ⬆️
...gement/form/EngagementWidgets/WidgetDrawerTabs.tsx 100.00% <ø> (ø)
...ement/form/EngagementWidgets/WidgetOptionCards.tsx 100.00% <ø> (ø)
...ponents/engagement/form/EngagementWidgets/type.tsx 100.00% <ø> (ø)
.../src/components/engagement/view/EngagementView.tsx 76.92% <ø> (-1.26%) ⬇️
met-web/src/models/widget.tsx 100.00% <ø> (ø)
...engagement/form/EngagementWidgets/WidgetsBlock.tsx 74.35% <57.14%> (-3.65%) ⬇️

... and 2 files with indirect coverage changes

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review May 31, 2024 19:29
Copy link
Collaborator

@ratheesh-aot ratheesh-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VineetBala-AOT VineetBala-AOT merged commit 6d13309 into main May 31, 2024
15 checks passed
@NatSquared NatSquared deleted the feature/deseng-626 branch June 26, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants