Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to Master #4320

Merged
merged 27 commits into from
Nov 21, 2024
Merged

Merge to Master #4320

merged 27 commits into from
Nov 21, 2024

Conversation

simranjeetgit
Copy link
Collaborator

LCSD-7382 & LCSD-7322

gary-jipp and others added 24 commits September 26, 2024 11:10
…tatement form" (#4291)

Revert "LCSD-7312: Add proof of valid interest back to Dormancy Reinstatement…"

This reverts commit c94ebfd.
SEP Application: Portion size is not getting calculated for free servings
* Add banner text for dynamics outage

* Update banner text
* LCSD-6147

SEP Checklist, add permit holder's responsibilities.
LCSD-6857 & LCSD-7322

Licensing - LP/LPC/LP Location Change - Update Floor Plan Requirement Language (Occupant Load Stamp)

Licensing – CM Lean – Floor Plans – 1 of 2 – Occupant Load (Fillable field)
* LCSD-6147

Adding permit holder's responsibilities to the checklist

* LCSD-6147
Adding permit holder's responsibilities to the checklist

* LCSD-6147

SEP Checklist, add permit holder's responsibilities.

* revert accidental changes on package-lock.json and package.json

* LCSD-7413 SEP refund policy

Adding SEP refund policy and checkbox
added refund policy for renewal applications
…on validation (#4303)

* added refund policy for renewal applications

* fix typo, move refund policy, add declaration validation

* fix typo
* LCSD-7322

Added checkbox for proposed capacity if the occupant load exceeds the total allowed load &  Content updates
* LCSD-6147

Adding permit holder's responsibilities to the checklist

* LCSD-6147
Adding permit holder's responsibilities to the checklist

* LCSD-6147

SEP Checklist, add permit holder's responsibilities.

* revert accidental changes on package-lock.json and package.json

* LCSD-7413 SEP refund policy

Adding SEP refund policy and checkbox

* LCSD-6465 remove "aircraft" from LP application

"aircraft" is not an establishment type and need to be removed.
* remove banner

* added closing section tag
* LCSD-7322 LG - Occupant load bug fix
* LCSD-7322 LG - Occupant load bug fix

* LCSD-7498 Updated SEP refund policy content
…erted Changes (#4316)

* added hours of sale

* revert unit tests and styling
 LCSD-7322

MFR bug fix
Rollback changes and excluded Outside Area capacity
commit 203c947
Author: simranjeetgit <[email protected]>
Date:   Mon Nov 18 15:09:27 2024 -0800

    Fixed build issues  (#4311)

    * Revert "LCSD-7312: Add proof of valid interest back to Dormancy Reinstatement form" (#4291)

    Revert "LCSD-7312: Add proof of valid interest back to Dormancy Reinstatement…"

    This reverts commit c94ebfd.

    * LCSD-7367 (#4294)

    SEP Application: Portion size is not getting calculated for free servings

    * LCSD-7483: Add banner for dynamics upgrade (#4296)

    * Add banner text for dynamics outage

    * Update banner text

    * LCSD-6147 (#4298)

    * LCSD-6147

    SEP Checklist, add permit holder's responsibilities.

    * Update banner text (#4297)

    * LCSD-6857 LCSD-7322 (#4300)

    LCSD-6857 & LCSD-7322

    Licensing - LP/LPC/LP Location Change - Update Floor Plan Requirement Language (Occupant Load Stamp)

    Licensing – CM Lean – Floor Plans – 1 of 2 – Occupant Load (Fillable field)

    * LCSD-7413 SEP refund policy (#4302)

    * LCSD-6147

    Adding permit holder's responsibilities to the checklist

    * LCSD-6147
    Adding permit holder's responsibilities to the checklist

    * LCSD-6147

    SEP Checklist, add permit holder's responsibilities.

    * revert accidental changes on package-lock.json and package.json

    * LCSD-7413 SEP refund policy

    Adding SEP refund policy and checkbox

    * LCSD-7414: Added refund policy for renewal applications (#4301)

    added refund policy for renewal applications

    * LCSD-7235: Fixed typo, rearrange refund policy section, add declaration validation (#4303)

    * added refund policy for renewal applications

    * fix typo, move refund policy, add declaration validation

    * fix typo

    * LCSD-7312: Add proof of valid interest back to dormancy reinstatement (#4299)

    * LCSD-7322 (#4304)

    * LCSD-7322

    Added checkbox for proposed capacity if the occupant load exceeds the total allowed load &  Content updates

    * Revert System Maintenance Banner (#4305)

    remove banner

    * LCSD-6465 remove "aircraft" from LP application (#4307)

    * LCSD-6147

    Adding permit holder's responsibilities to the checklist

    * LCSD-6147
    Adding permit holder's responsibilities to the checklist

    * LCSD-6147

    SEP Checklist, add permit holder's responsibilities.

    * revert accidental changes on package-lock.json and package.json

    * LCSD-7413 SEP refund policy

    Adding SEP refund policy and checkbox

    * LCSD-6465 remove "aircraft" from LP application

    "aircraft" is not an establishment type and need to be removed.

    * Add closing section (#4309)

    * remove banner

    * added closing section tag

    * Fixed merge issues

    ---------

    Co-authored-by: gary-jipp <[email protected]>
    Co-authored-by: Vijaivir Dhaliwal <[email protected]>
    Co-authored-by: JSuiBCGov <[email protected]>
    Co-authored-by: Sam Warren <[email protected]>
Merge branch 'master' of https://github.com/bcgov/jag-lcrb-carla-public into develop
vijaivir
vijaivir previously approved these changes Nov 21, 2024
@vijaivir vijaivir dismissed their stale review November 21, 2024 21:40

the 'Hours of Sale' is duplicated

Copy link
Collaborator

@vijaivir vijaivir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR duplicates the Hours of Sale section. That code has already been pushed to master.

@simranjeetgit simranjeetgit merged commit 61ceeb6 into master Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants