Add Heading and Text components #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* staging Accordion and AccordionGroup file structure * bump RAC to 1.4.0 * basic shape of Accordion component * tweak props import * add story wireframe for Accordion * styling accordion * styling * additional styling and alternative icon implementation * refining button styling * scaffolding AccordionGroup * add title prop and styling to AccordionGroup * continuing work on Accordion and AccordionGroup styling * fix focus state for accordions inside accordiongroup * fleshing out argTypes * scaffolding accordion docs * add examples to vite kitchen sink * fleshing out examples on vite * expanding stories and docs * stories and docs * typo * renaming CSS classes to bcds-react-aria-* to match convention * typo * add comments to accordion group props * remove unused CSS class * bump RAC to 1.5.0 * update RAC imports
Fixed in 5504f6f! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the RAC Heading and Text utility components into the B.C. Design System:
These components are intended to be used internally within other components, and to provide a straightforward way for users to compose sections of content within their interfaces using the BCDS typescale.
Both components are styled. The
colorprop enables the user to set text colour, from the design system's colour palette. Content is populated via thechildrenslot.The user can override styling using these props:
className: replaces BCDS CSS classisUnstyled: removes CSS classes entirely, allowing components to inherit their styling from parent elementsHeading
Heading also accepts these props:
level: used to set the heading type, fromh1toh6Text
Text also accepts these props:
elementType: sets the type of HTML element rendered (defaults tospan)size: sets the text size (defaults tomedium, also includeslargeandsmall)