Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1303 restrict rate limit to api routes #1524

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

WalterMoar
Copy link
Collaborator

Description

The express rate limiter is now applied globally, so that all routes are included. However, it needs to be restricted to only the API - the Vue files, etc, should not be involved in the rate limiting.

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

The express rate limiter is now applied globally, so that all routes are included. However, it needs to be restricted to only the API - the Vue files, etc, should not be involved in the rate limiting.
@WalterMoar WalterMoar marked this pull request as ready for review October 23, 2024 15:27
@WalterMoar WalterMoar merged commit 5f754dc into bcgov:main Oct 23, 2024
5 checks passed
@WalterMoar WalterMoar deleted the fix/1303-restrict-rate-limit branch October 23, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant