392 button tech debt #2519
392 button tech debt #2519
Conversation
gdalcengio
commented
Nov 25, 2024
gdalcengio
commented
- feat: Add reporting step buttons component for reporting forms, separating save and continue buttons
- chore: Add reporting step buttons to facility review page
…ating save and continue buttons
| @@ -44,10 +44,11 @@ const PersonResponsible = ({ version_id }: Props) => { | |||
| const router = useRouter(); | |||
|
|
|||
| const queryString = serializeSearchParams(useSearchParams()); | |||
| const saveAndContinueUrl = | |||
| const continueUrl = | |||
| operationType === "Linear Facility Operation" | |||
| ? `/reports/${version_id}/facilities/lfo-facilities${queryString}` | |||
| : `/reports/${version_id}/facilities/${facilityId}/review${queryString}&facilities_title=Facility`; | |||
There was a problem hiding this comment.
There is an issue here with this path. When queryString is null, we get:
.../review&facilities_title=Facility, which doesn't parse properly because we don't have the ? before the query params.
A potential solution (which would need to be investigated for side effects) is to change the serializeSearchParams utility function to return ? when there are no params & append & to the end of the querystring when there are.
We'd have to look at where serializeSearchParams is used & make sure everything still works as expected where it's implemented
There was a problem hiding this comment.
To reproduce the bug, start a report & get to the Person Responsible page, once you enter data there & click Save&Continue, you'll get a 404 error because the params are missing the ? to start them off
