Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sha256 hash over the OCA Bundles file to the generated JSON lists of bundles #106

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add a sha256 hash over the OCA Bundles file to the generated JSON lists of bundles #106

merged 1 commit into from
Dec 4, 2023

Conversation

swcurran
Copy link
Contributor

This addresses #82 by adding a sha256 hash over the OCA Bundle to the JSON lists of bundles. A client can load the list and check the hash against a saved value to determine if the OCA Bundles needs to be reloaded.

@wadeking98 -- still a bit nervous this will break production. Could you run a local test of the current released BC Wallet code using my branch (https://github.com/swcurran/aries-oca-bundles/tree/add-sha256-hash) that I'm trying to merge to make sure that the updated JSON file with the sha256 field added doesn't break anything in the released BC Wallet people are using?

If you are confident -- feel free to approve :-)

Copy link
Contributor

@wadeking98 wadeking98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing and working with local copy (tested LSBC test credential and IDIM prod person credential)

@swcurran swcurran merged commit 2dda84c into bcgov:main Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants