Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[AGRI-NMP-709]: Missing Calculated Nutrients when Editing #719

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Fix[AGRI-NMP-709]: Missing Calculated Nutrients when Editing #719

merged 2 commits into from
Jan 4, 2025

Conversation

lunamoonmoon
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • change so calculate button is triggered when edit modal opened
  • Screenshot 2025-01-03 at 3 44 05 PM

(Ticket 718 created to address bug related to editing dry fertigation)

@PaulGarewal PaulGarewal self-requested a review January 4, 2025 00:13
PaulGarewal
PaulGarewal approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@PaulGarewal PaulGarewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lunamoonmoon lunamoonmoon marked this pull request as ready for review January 4, 2025 00:19
@lunamoonmoon lunamoonmoon merged commit 5e0721f into master Jan 4, 2025
4 checks passed
@lunamoonmoon lunamoonmoon deleted the 709fixsections branch January 4, 2025 00:19
@lunamoonmoon lunamoonmoon linked an issue Jan 4, 2025 that may be closed by this pull request
Add/Fix missing sections when editing a Fertigation #709
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulGarewal PaulGarewal PaulGarewal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/Fix missing sections when editing a Fertigation
2 participants
@lunamoonmoon @PaulGarewal